feat: convert all agents to native skill format#12
Merged
Conversation
Convert 6 agent YAML files to the unified skill directory pattern with SKILL.md + bmad-skill-manifest.yaml per agent. Update module-help.csv to use skill: references. Remove teams folder. Agents converted: Victor (Innovation Strategist), Dr. Quinn (Problem Solver), Maya (Design Thinking), Caravaggio (Presentation), Carson (Brainstorming), Sophia (Storyteller with sidecar files). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
WalkthroughSix declarative agent YAML files and related team/docs/tests/validation were removed and replaced by new native skill artifacts (SKILL.md + skill manifests); CI schema validation and many agent-schema fixtures/tests were also deleted and some documentation/team config updated. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: This PR migrates CIS personas from legacy Changes:
Technical Notes: Agent skills now route into existing CIS workflow skills (e.g. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| @@ -1,21 +0,0 @@ | |||
| # Elite Brainstorming Specialist Agent Definition | |||
There was a problem hiding this comment.
This PR removes all *.agent.yaml files under src/, but npm test still runs test/validate-agent-schema.js which exits non-zero when it finds zero agent files (glob('src/**/*.agent.yaml')). That means CI/local tests will likely fail unless the schema validation step is updated/removed as part of the migration.
Severity: high
Other Locations
src/agents/creative-problem-solver.agent.yaml:1src/agents/design-thinking-coach.agent.yaml:1src/agents/innovation-strategist.agent.yaml:1src/agents/presentation-master.agent.yaml:1src/agents/storyteller/storyteller.agent.yaml:1
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| | Code | Description | Skill | | ||
| |------|-------------|-------| | ||
| | SD | Create multi-slide presentation with professional layouts and visual hierarchy | todo | |
There was a problem hiding this comment.
The Capabilities table uses todo as the registered Skill name, but the "CRITICAL Handling" section instructs invoking the skill exactly as listed; unless a real todo skill exists, these menu options will fail at runtime.
Severity: medium
Other Locations
src/agents/cis-agent-presentation-master/SKILL.md:40src/agents/cis-agent-presentation-master/SKILL.md:41src/agents/cis-agent-presentation-master/SKILL.md:42src/agents/cis-agent-presentation-master/SKILL.md:43src/agents/cis-agent-presentation-master/SKILL.md:44src/agents/cis-agent-presentation-master/SKILL.md:45
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| @@ -1,7 +0,0 @@ | |||
| # <!-- Powered by BMAD-CORE™ --> | |||
There was a problem hiding this comment.
With src/teams/creative-squad.yaml removed, the docs still describing the "Creative Squad Team" (e.g. in docs/reference/agents.md) may now be stale/misleading if teams are no longer supported/exposed for CIS.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
src/agents/cis-agent-brainstorming-coach/SKILL.md (1)
26-26: Tighten persona instruction grammar for clarity.Line 26 has wording issues (“its”, “users dismisses”) that make the directive less clear.
✍️ Suggested wording
-You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. +You must fully embody this persona so the user gets the best experience and support they need. Do not break character until the user dismisses this persona.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/agents/cis-agent-brainstorming-coach/SKILL.md` at line 26, Update the sentence "You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona." to fix grammar and clarity: change "its" to "it's" (it is), change "users dismisses" to "user dismisses", and add proper punctuation for readability—e.g., "You must fully embody this persona so the user gets the best experience and help they need; therefore it's important to remember you must not break character until the user dismisses this persona."
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/agents/cis-agent-creative-problem-solver/SKILL.md`:
- Line 26: Fix the persona lock-in sentence in SKILL.md by correcting grammar
and punctuation: change "its important" to "it's important" (or "it is
important") and "users dismisses" to "the user dismisses" (or "users dismiss")
so the sentence reads clearly and consistently (e.g., "You must fully embody
this persona so the user gets the best experience and help they need; therefore
it's important to remember you must not break character until the user dismisses
this persona."). Update the sentence in the persona lock-in paragraph
accordingly.
In `@src/agents/cis-agent-design-thinking-coach/bmad-skill-manifest.yaml`:
- Around line 1-12: The manifest discovery currently only matches "*.agent.yaml"
so the schema validator doesn't find migrated manifests; update the discovery
logic (e.g., the function handling manifest discovery such as discoverAgentFiles
or findAgentManifests) to also accept "bmad-skill-manifest.yaml" (either add it
to the glob list or expand the pattern to include both filenames), and update
the test/README.md reference on line 7 to mention "bmad-skill-manifest.yaml"
instead of "*.agent.yaml".
In `@src/agents/cis-agent-design-thinking-coach/SKILL.md`:
- Line 27: The persona contract sentence in SKILL.md currently reads with
grammatical errors ("its" and "users dismisses"); update the sentence in the
persona block so it reads cleanly — e.g., change "its important to remember you
must not break character until the users dismisses this persona." to "it's
important to remember you must not break character until the user dismisses this
persona." — make the replacement in the SKILL.md persona contract (the sentence
containing "its important to remember" and "users dismisses") so punctuation and
subject-verb agreement are correct.
In `@src/agents/cis-agent-presentation-master/SKILL.md`:
- Around line 37-46: The SKILL.md table contains placeholder "todo" values for
the Skill column (rows identified by codes SD, EX, PD, CT, IN, VM, CV) which
prevents invocation; replace each "todo" with the exact registered skill ID
string used by the system for that capability (e.g., the canonical skill names
in the skill registry), ensuring they match casing and punctuation exactly, and
update the corresponding reference elsewhere in the file where the agent expects
the exact registered name (the explicit reference noted in the review) so all
entries are callable.
In `@src/agents/cis-agent-storyteller/SKILL.md`:
- Line 31: Fix the grammatical errors in the persona persistence sentence in
SKILL.md: replace "therefore its important to remember you must not break
character until the users dismisses this persona." with a corrected sentence
such as "Therefore, it's important to remember you must not break character
until the user dismisses this persona." Ensure the capitalization and
punctuation (leading "Therefore," and contraction "it's") and singular "user
dismisses" are applied to the existing persona instruction.
- Around line 28-30: Update the hardcoded sidecar paths in SKILL.md to point to
the agent-local memory files: replace references to
`{project-root}/_bmad/_memory/storyteller-sidecar/story-preferences.md` and
`{project-root}/_bmad/_memory/storyteller-sidecar/stories-told.md` with their
new agent directory locations (the moved files inside the agent folder),
ensuring any activation/load instructions or examples that reference
`story-preferences.md` and `stories-told.md` use the new agent-relative paths so
activation won’t fail.
---
Nitpick comments:
In `@src/agents/cis-agent-brainstorming-coach/SKILL.md`:
- Line 26: Update the sentence "You must fully embody this persona so the user
gets the best experience and help they need, therefore its important to remember
you must not break character until the users dismisses this persona." to fix
grammar and clarity: change "its" to "it's" (it is), change "users dismisses" to
"user dismisses", and add proper punctuation for readability—e.g., "You must
fully embody this persona so the user gets the best experience and help they
need; therefore it's important to remember you must not break character until
the user dismisses this persona."
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 00fc94e6-88b6-4cb9-9c5c-844bc33e8c9b
⛔ Files ignored due to path filters (2)
src/module-help.csvis excluded by!**/*.csvsrc/teams/default-party.csvis excluded by!**/*.csv
📒 Files selected for processing (22)
src/agents/brainstorming-coach.agent.yamlsrc/agents/cis-agent-brainstorming-coach/SKILL.mdsrc/agents/cis-agent-brainstorming-coach/bmad-skill-manifest.yamlsrc/agents/cis-agent-creative-problem-solver/SKILL.mdsrc/agents/cis-agent-creative-problem-solver/bmad-skill-manifest.yamlsrc/agents/cis-agent-design-thinking-coach/SKILL.mdsrc/agents/cis-agent-design-thinking-coach/bmad-skill-manifest.yamlsrc/agents/cis-agent-innovation-strategist/SKILL.mdsrc/agents/cis-agent-innovation-strategist/bmad-skill-manifest.yamlsrc/agents/cis-agent-presentation-master/SKILL.mdsrc/agents/cis-agent-presentation-master/bmad-skill-manifest.yamlsrc/agents/cis-agent-storyteller/SKILL.mdsrc/agents/cis-agent-storyteller/bmad-skill-manifest.yamlsrc/agents/cis-agent-storyteller/stories-told.mdsrc/agents/cis-agent-storyteller/story-preferences.mdsrc/agents/creative-problem-solver.agent.yamlsrc/agents/design-thinking-coach.agent.yamlsrc/agents/innovation-strategist.agent.yamlsrc/agents/presentation-master.agent.yamlsrc/agents/storyteller/storyteller.agent.yamlsrc/teams/creative-squad.yamlsrc/workflows/README.md
💤 Files with no reviewable changes (8)
- src/teams/creative-squad.yaml
- src/agents/presentation-master.agent.yaml
- src/agents/innovation-strategist.agent.yaml
- src/agents/creative-problem-solver.agent.yaml
- src/agents/brainstorming-coach.agent.yaml
- src/workflows/README.md
- src/agents/storyteller/storyteller.agent.yaml
- src/agents/design-thinking-coach.agent.yaml
| - Hunt for root causes relentlessly. | ||
| - The right question beats a fast answer. | ||
|
|
||
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. |
There was a problem hiding this comment.
Polish grammar in the persona lock-in sentence.
Line 26 has the same grammatical issues (its, users dismisses). Please correct to improve prompt clarity and consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/agents/cis-agent-creative-problem-solver/SKILL.md` at line 26, Fix the
persona lock-in sentence in SKILL.md by correcting grammar and punctuation:
change "its important" to "it's important" (or "it is important") and "users
dismisses" to "the user dismisses" (or "users dismiss") so the sentence reads
clearly and consistently (e.g., "You must fully embody this persona so the user
gets the best experience and help they need; therefore it's important to
remember you must not break character until the user dismisses this persona.").
Update the sentence in the persona lock-in paragraph accordingly.
Comment on lines
+1
to
+12
| type: agent | ||
| name: cis-agent-design-thinking-coach | ||
| displayName: Maya | ||
| title: Design Thinking Maestro | ||
| icon: "🎨" | ||
| capabilities: "human-centered design, empathy mapping, prototyping, user insights" | ||
| role: "Human-Centered Design Expert + Empathy Architect" | ||
| identity: "Design thinking virtuoso with 15+ years at Fortune 500s and startups. Expert in empathy mapping, prototyping, and user insights." | ||
| communicationStyle: "Talks like a jazz musician - improvises around themes, uses vivid sensory metaphors, playfully challenges assumptions" | ||
| principles: "Design is about THEM not us. Validate through real human interaction. Failure is feedback. Design WITH users not FOR them." | ||
| module: cis | ||
| canonicalId: cis-agent-design-thinking-coach |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Current validator patterns:"
rg -n -C3 "agent\\.yaml|bmad-skill-manifest|No agent files found" test/validate-agent-schema.js test/README.md
echo
echo "Count new-format manifests:"
fd 'bmad-skill-manifest.yaml$' src | wc -l
echo
echo "Count legacy agent yamls:"
fd '\.agent\.yaml$' src | wc -lRepository: bmad-code-org/bmad-module-creative-intelligence-suite
Length of output: 1846
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Check if validator is in package.json test scripts ==="
grep -n "validate-agent-schema\|test" package.json | head -20 || echo "(no results)"
echo
echo "=== Check for any CI config files ==="
find . -maxdepth 2 -name ".github" -o -name ".gitlab-ci.yml" -o -name ".circleci" -o -name "Makefile" 2>/dev/null | head -10
echo
echo "=== Search all references to old pattern in non-test files ==="
rg '\.agent\.yaml|agent\.yaml' --type yaml --type js --type json src/ tools/ .github/ 2>/dev/null | grep -v node_modules | head -20 || echo "(no results)"
echo
echo "=== Verify the exact glob call in validate-agent-schema.js ==="
sed -n '30,50p' test/validate-agent-schema.jsRepository: bmad-code-org/bmad-module-creative-intelligence-suite
Length of output: 1235
Update schema-validation discovery to include bmad-skill-manifest.yaml.
The validator currently scans for *.agent.yaml but all agent manifests have been migrated to bmad-skill-manifest.yaml. This causes validation to fail with "No agent files found" and exit with error code 1, breaking the test suite in CI.
🛠️ Suggested fix
--- a/test/validate-agent-schema.js
+++ b/test/validate-agent-schema.js
@@ -32,17 +32,17 @@ async function main(customProjectRoot) {
const project_root = customProjectRoot || path.join(__dirname, '..');
// Find all agent files
- const agentFiles = await glob('src/**/*.agent.yaml', {
+ const agentFiles = await glob('src/**/bmad-skill-manifest.yaml', {
cwd: project_root,
absolute: true,
});
if (agentFiles.length === 0) {
- console.log('❌ No agent files found. This likely indicates a configuration error.');
- console.log(' Expected to find *.agent.yaml files in src/{core,modules/*}/agents/');
+ console.log('❌ No skill manifest files found. This likely indicates a configuration error.');
+ console.log(' Expected to find bmad-skill-manifest.yaml files in src/**/agents/');
process.exit(1);
}Also update test/README.md line 7 to reference the new manifest filename instead of *.agent.yaml.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/agents/cis-agent-design-thinking-coach/bmad-skill-manifest.yaml` around
lines 1 - 12, The manifest discovery currently only matches "*.agent.yaml" so
the schema validator doesn't find migrated manifests; update the discovery logic
(e.g., the function handling manifest discovery such as discoverAgentFiles or
findAgentManifests) to also accept "bmad-skill-manifest.yaml" (either add it to
the glob list or expand the pattern to include both filenames), and update the
test/README.md reference on line 7 to mention "bmad-skill-manifest.yaml" instead
of "*.agent.yaml".
| - Failure is feedback. | ||
| - Design WITH users not FOR them. | ||
|
|
||
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. |
There was a problem hiding this comment.
Fix user-facing grammar in persona contract text.
Line 27 has grammatical issues that reduce prompt clarity (its, users dismisses).
✏️ Suggested text fix
-You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona.
+You must fully embody this persona so the user gets the best experience and help they need; therefore, it's important to remember that you must not break character until the user dismisses this persona.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. | |
| You must fully embody this persona so the user gets the best experience and help they need; therefore, it's important to remember that you must not break character until the user dismisses this persona. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/agents/cis-agent-design-thinking-coach/SKILL.md` at line 27, The persona
contract sentence in SKILL.md currently reads with grammatical errors ("its" and
"users dismisses"); update the sentence in the persona block so it reads cleanly
— e.g., change "its important to remember you must not break character until the
users dismisses this persona." to "it's important to remember you must not break
character until the user dismisses this persona." — make the replacement in the
SKILL.md persona contract (the sentence containing "its important to remember"
and "users dismisses") so punctuation and subject-verb agreement are correct.
Comment on lines
+37
to
+46
| | Code | Description | Skill | | ||
| |------|-------------|-------| | ||
| | SD | Create multi-slide presentation with professional layouts and visual hierarchy | todo | | ||
| | EX | Design YouTube/video explainer layout with visual script and engagement hooks | todo | | ||
| | PD | Craft investor pitch presentation with data visualization and narrative arc | todo | | ||
| | CT | Build conference talk or workshop presentation materials with speaker notes | todo | | ||
| | IN | Design creative information visualization with visual storytelling | todo | | ||
| | VM | Create conceptual illustrations (Rube Goldberg machines, journey maps, creative processes) | todo | | ||
| | CV | Generate single expressive image that explains ideas creatively and memorably | todo | | ||
|
|
There was a problem hiding this comment.
Replace placeholder todo entries with real skill IDs before release.
Lines 39-46 currently cannot be invoked, and Line 62 explicitly requires exact registered names. This breaks capability execution for this agent.
✅ Minimal fix pattern
| Code | Description | Skill |
|------|-------------|-------|
-| SD | Create multi-slide presentation with professional layouts and visual hierarchy | todo |
-| EX | Design YouTube/video explainer layout with visual script and engagement hooks | todo |
-| PD | Craft investor pitch presentation with data visualization and narrative arc | todo |
-| CT | Build conference talk or workshop presentation materials with speaker notes | todo |
-| IN | Design creative information visualization with visual storytelling | todo |
-| VM | Create conceptual illustrations (Rube Goldberg machines, journey maps, creative processes) | todo |
-| CV | Generate single expressive image that explains ideas creatively and memorably | todo |
+| SD | Create multi-slide presentation with professional layouts and visual hierarchy | <registered-skill-id> |
+| EX | Design YouTube/video explainer layout with visual script and engagement hooks | <registered-skill-id> |
+| PD | Craft investor pitch presentation with data visualization and narrative arc | <registered-skill-id> |
+| CT | Build conference talk or workshop presentation materials with speaker notes | <registered-skill-id> |
+| IN | Design creative information visualization with visual storytelling | <registered-skill-id> |
+| VM | Create conceptual illustrations (Rube Goldberg machines, journey maps, creative processes) | <registered-skill-id> |
+| CV | Generate single expressive image that explains ideas creatively and memorably | <registered-skill-id> |Also applies to: 62-62
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/agents/cis-agent-presentation-master/SKILL.md` around lines 37 - 46, The
SKILL.md table contains placeholder "todo" values for the Skill column (rows
identified by codes SD, EX, PD, CT, IN, VM, CV) which prevents invocation;
replace each "todo" with the exact registered skill ID string used by the system
for that capability (e.g., the canonical skill names in the skill registry),
ensuring they match casing and punctuation exactly, and update the corresponding
reference elsewhere in the file where the agent expects the exact registered
name (the explicit reference noted in the review) so all entries are callable.
Comment on lines
+28
to
+30
| - Load COMPLETE file `{project-root}/_bmad/_memory/storyteller-sidecar/story-preferences.md` and review remember the User Preferences | ||
| - Load COMPLETE file `{project-root}/_bmad/_memory/storyteller-sidecar/stories-told.md` and review the history of stories created for this user | ||
|
|
There was a problem hiding this comment.
Critical actions still reference the old sidecar location.
Lines 28–30 point to {project-root}/_bmad/_memory/storyteller-sidecar/..., but this PR’s objective says those files were moved into the agent directory. This can cause failed loads at activation time.
🛠️ Suggested path update
-- Load COMPLETE file `{project-root}/_bmad/_memory/storyteller-sidecar/story-preferences.md` and review remember the User Preferences
-- Load COMPLETE file `{project-root}/_bmad/_memory/storyteller-sidecar/stories-told.md` and review the history of stories created for this user
+- Load COMPLETE file `{project-root}/src/agents/cis-agent-storyteller/story-preferences.md` and review the user preferences
+- Load COMPLETE file `{project-root}/src/agents/cis-agent-storyteller/stories-told.md` and review the history of stories created for this user🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/agents/cis-agent-storyteller/SKILL.md` around lines 28 - 30, Update the
hardcoded sidecar paths in SKILL.md to point to the agent-local memory files:
replace references to
`{project-root}/_bmad/_memory/storyteller-sidecar/story-preferences.md` and
`{project-root}/_bmad/_memory/storyteller-sidecar/stories-told.md` with their
new agent directory locations (the moved files inside the agent folder),
ensuring any activation/load instructions or examples that reference
`story-preferences.md` and `stories-told.md` use the new agent-relative paths so
activation won’t fail.
| - Load COMPLETE file `{project-root}/_bmad/_memory/storyteller-sidecar/story-preferences.md` and review remember the User Preferences | ||
| - Load COMPLETE file `{project-root}/_bmad/_memory/storyteller-sidecar/stories-told.md` and review the history of stories created for this user | ||
|
|
||
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. |
There was a problem hiding this comment.
Fix grammar in persona persistence instruction.
Line 31 has grammatical issues (its, users dismisses) in user-facing instruction text.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/agents/cis-agent-storyteller/SKILL.md` at line 31, Fix the grammatical
errors in the persona persistence sentence in SKILL.md: replace "therefore its
important to remember you must not break character until the users dismisses
this persona." with a corrected sentence such as "Therefore, it's important to
remember you must not break character until the user dismisses this persona."
Ensure the capitalization and punctuation (leading "Therefore," and contraction
"it's") and singular "user dismisses" are applied to the existing persona
instruction.
Agent YAML files no longer exist after skill conversion. Remove test/ directory, schema validation scripts, and CI validate job. Add package-lock.json for CI cache support. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ad-cis naming - Move all agent folders from src/agents/ to src/skills/ - Move non-agent workflow folders from src/workflows/ to src/skills/ - Rename workflow folders from cis-agent-* to bmad-cis-agent-* - Update SKILL.md name fields to use bmad-cis- prefix consistently
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md (1)
51-51: Consider using markdown heading for consistency.The "CRITICAL Handling:" label uses bold text with a colon, which is inconsistent with the markdown heading structure used elsewhere (e.g.,
## Identity,## Principles). Consider using a heading for better structural consistency.♻️ Proposed formatting improvement
-**CRITICAL Handling:** When user responds with a code, line number or skill, invoke the corresponding skill by its exact registered name from the Capabilities table. DO NOT invent capabilities on the fly. +### Critical Handling + +When user responds with a code, line number or skill, invoke the corresponding skill by its exact registered name from the Capabilities table. DO NOT invent capabilities on the fly.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md` at line 51, Replace the bold "CRITICAL Handling:" label with a markdown heading to match the rest of the document; locate the line containing "**CRITICAL Handling:** When user responds with a code, line number or skill, invoke the corresponding skill by its exact registered name from the Capabilities table. DO NOT invent capabilities on the fly." and change it to a heading (e.g., "## Critical handling" or "### Critical Handling") while preserving the exact instruction text and emphasis on invoking skills by their registered names from the Capabilities table.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 34: The test script currently runs only style checks ("test": "npm run
lint && npm run lint:md && npm run format:check") so CI no longer validates
skill wiring; add or invoke a skill-validation smoke script (e.g., create
"validate:skills" or reuse existing skill check script) and include it in the
"test" pipeline so "npm test" runs style checks plus at least one automated
skill manifest/skill: reference validation step; update the "test" script to run
the new/existing skill validator after the lint/format steps and ensure the
validator exits non‑zero on failures.
In `@src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md`:
- Line 26: Fix the grammatical contraction in the SKILL.md sentence "You must
fully embody this persona so the user gets the best experience and help they
need, therefore its important to remember you must not break character until the
users dismisses this persona." by replacing "its important" with "it's
important" and also consider fixing "users dismisses" to "user dismisses" or
"users dismiss" as appropriate; locate the exact sentence in SKILL.md and apply
the contraction and plural noun fix so the line reads grammatically correct.
In `@src/skills/bmad-cis-agent-presentation-master/SKILL.md`:
- Line 31: The sentence in SKILL.md that reads "until the users dismisses this
persona" has a subject-verb agreement error; update that fragment to "until the
user dismisses this persona" (change "users dismisses" to "user dismisses") so
the subject and verb agree; locate the sentence in the SKILL.md content block
for the persona description and replace the plural/incorrect form with the
singular/correct form.
---
Nitpick comments:
In `@src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md`:
- Line 51: Replace the bold "CRITICAL Handling:" label with a markdown heading
to match the rest of the document; locate the line containing "**CRITICAL
Handling:** When user responds with a code, line number or skill, invoke the
corresponding skill by its exact registered name from the Capabilities table. DO
NOT invent capabilities on the fly." and change it to a heading (e.g., "##
Critical handling" or "### Critical Handling") while preserving the exact
instruction text and emphasis on invoking skills by their registered names from
the Capabilities table.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8433638c-14c2-4c56-b7a9-2f49aa43ec04
⛔ Files ignored due to path filters (5)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/skills/bmad-cis-design-thinking/design-methods.csvis excluded by!**/*.csvsrc/skills/bmad-cis-innovation-strategy/innovation-frameworks.csvis excluded by!**/*.csvsrc/skills/bmad-cis-problem-solving/solving-methods.csvis excluded by!**/*.csvsrc/skills/bmad-cis-storytelling/story-types.csvis excluded by!**/*.csv
📒 Files selected for processing (90)
.github/workflows/quality.yaml.gitignorepackage.jsonsrc/skills/bmad-cis-agent-brainstorming-coach/SKILL.mdsrc/skills/bmad-cis-agent-brainstorming-coach/bmad-skill-manifest.yamlsrc/skills/bmad-cis-agent-creative-problem-solver/SKILL.mdsrc/skills/bmad-cis-agent-creative-problem-solver/bmad-skill-manifest.yamlsrc/skills/bmad-cis-agent-design-thinking-coach/SKILL.mdsrc/skills/bmad-cis-agent-design-thinking-coach/bmad-skill-manifest.yamlsrc/skills/bmad-cis-agent-innovation-strategist/SKILL.mdsrc/skills/bmad-cis-agent-innovation-strategist/bmad-skill-manifest.yamlsrc/skills/bmad-cis-agent-presentation-master/SKILL.mdsrc/skills/bmad-cis-agent-presentation-master/bmad-skill-manifest.yamlsrc/skills/bmad-cis-agent-storyteller/SKILL.mdsrc/skills/bmad-cis-agent-storyteller/bmad-skill-manifest.yamlsrc/skills/bmad-cis-agent-storyteller/stories-told.mdsrc/skills/bmad-cis-agent-storyteller/story-preferences.mdsrc/skills/bmad-cis-design-thinking/SKILL.mdsrc/skills/bmad-cis-design-thinking/bmad-skill-manifest.yamlsrc/skills/bmad-cis-design-thinking/template.mdsrc/skills/bmad-cis-design-thinking/workflow.mdsrc/skills/bmad-cis-innovation-strategy/SKILL.mdsrc/skills/bmad-cis-innovation-strategy/bmad-skill-manifest.yamlsrc/skills/bmad-cis-innovation-strategy/template.mdsrc/skills/bmad-cis-innovation-strategy/workflow.mdsrc/skills/bmad-cis-problem-solving/SKILL.mdsrc/skills/bmad-cis-problem-solving/bmad-skill-manifest.yamlsrc/skills/bmad-cis-problem-solving/template.mdsrc/skills/bmad-cis-problem-solving/workflow.mdsrc/skills/bmad-cis-storytelling/SKILL.mdsrc/skills/bmad-cis-storytelling/bmad-skill-manifest.yamlsrc/skills/bmad-cis-storytelling/template.mdsrc/skills/bmad-cis-storytelling/workflow.mdtest/README.mdtest/fixtures/agent-schema/invalid/critical-actions/actions-as-string.agent.yamltest/fixtures/agent-schema/invalid/critical-actions/empty-string-in-actions.agent.yamltest/fixtures/agent-schema/invalid/menu-commands/empty-command-target.agent.yamltest/fixtures/agent-schema/invalid/menu-commands/no-command-target.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/camel-case.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/compound-invalid-format.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/compound-mismatched-kebab.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/duplicate-triggers.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/empty-trigger.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/leading-asterisk.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/snake-case.agent.yamltest/fixtures/agent-schema/invalid/menu-triggers/trigger-with-spaces.agent.yamltest/fixtures/agent-schema/invalid/menu/empty-menu.agent.yamltest/fixtures/agent-schema/invalid/menu/missing-menu.agent.yamltest/fixtures/agent-schema/invalid/metadata/empty-module-string.agent.yamltest/fixtures/agent-schema/invalid/metadata/empty-name.agent.yamltest/fixtures/agent-schema/invalid/metadata/extra-metadata-fields.agent.yamltest/fixtures/agent-schema/invalid/metadata/missing-id.agent.yamltest/fixtures/agent-schema/invalid/persona/empty-principles-array.agent.yamltest/fixtures/agent-schema/invalid/persona/empty-string-in-principles.agent.yamltest/fixtures/agent-schema/invalid/persona/extra-persona-fields.agent.yamltest/fixtures/agent-schema/invalid/persona/missing-role.agent.yamltest/fixtures/agent-schema/invalid/prompts/empty-content.agent.yamltest/fixtures/agent-schema/invalid/prompts/extra-prompt-fields.agent.yamltest/fixtures/agent-schema/invalid/prompts/missing-content.agent.yamltest/fixtures/agent-schema/invalid/prompts/missing-id.agent.yamltest/fixtures/agent-schema/invalid/top-level/empty-file.agent.yamltest/fixtures/agent-schema/invalid/top-level/extra-top-level-keys.agent.yamltest/fixtures/agent-schema/invalid/top-level/missing-agent-key.agent.yamltest/fixtures/agent-schema/invalid/yaml-errors/invalid-indentation.agent.yamltest/fixtures/agent-schema/invalid/yaml-errors/malformed-yaml.agent.yamltest/fixtures/agent-schema/valid/critical-actions/empty-critical-actions.agent.yamltest/fixtures/agent-schema/valid/critical-actions/no-critical-actions.agent.yamltest/fixtures/agent-schema/valid/critical-actions/valid-critical-actions.agent.yamltest/fixtures/agent-schema/valid/menu-commands/all-command-types.agent.yamltest/fixtures/agent-schema/valid/menu-commands/multiple-commands.agent.yamltest/fixtures/agent-schema/valid/menu-triggers/compound-triggers.agent.yamltest/fixtures/agent-schema/valid/menu-triggers/kebab-case-triggers.agent.yamltest/fixtures/agent-schema/valid/menu/multiple-menu-items.agent.yamltest/fixtures/agent-schema/valid/menu/single-menu-item.agent.yamltest/fixtures/agent-schema/valid/metadata/core-agent-with-module.agent.yamltest/fixtures/agent-schema/valid/metadata/empty-module-name-in-path.agent.yamltest/fixtures/agent-schema/valid/metadata/malformed-path-treated-as-core.agent.yamltest/fixtures/agent-schema/valid/metadata/module-agent-correct.agent.yamltest/fixtures/agent-schema/valid/metadata/module-agent-missing-module.agent.yamltest/fixtures/agent-schema/valid/metadata/wrong-module-value.agent.yamltest/fixtures/agent-schema/valid/persona/complete-persona.agent.yamltest/fixtures/agent-schema/valid/prompts/empty-prompts.agent.yamltest/fixtures/agent-schema/valid/prompts/no-prompts.agent.yamltest/fixtures/agent-schema/valid/prompts/valid-prompts-minimal.agent.yamltest/fixtures/agent-schema/valid/prompts/valid-prompts-with-description.agent.yamltest/fixtures/agent-schema/valid/top-level/minimal-core-agent.agent.yamltest/schema/agent.jstest/test-agent-schema.jstest/unit-test-schema.jstest/validate-agent-schema.js
💤 Files with no reviewable changes (59)
- test/fixtures/agent-schema/invalid/top-level/empty-file.agent.yaml
- test/fixtures/agent-schema/invalid/menu-commands/empty-command-target.agent.yaml
- .gitignore
- test/fixtures/agent-schema/valid/critical-actions/valid-critical-actions.agent.yaml
- test/fixtures/agent-schema/invalid/prompts/extra-prompt-fields.agent.yaml
- test/fixtures/agent-schema/invalid/menu/missing-menu.agent.yaml
- test/fixtures/agent-schema/invalid/metadata/empty-module-string.agent.yaml
- test/fixtures/agent-schema/invalid/yaml-errors/malformed-yaml.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/compound-mismatched-kebab.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/empty-trigger.agent.yaml
- test/fixtures/agent-schema/valid/persona/complete-persona.agent.yaml
- test/fixtures/agent-schema/valid/critical-actions/no-critical-actions.agent.yaml
- test/fixtures/agent-schema/invalid/metadata/missing-id.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/compound-invalid-format.agent.yaml
- test/fixtures/agent-schema/invalid/menu-commands/no-command-target.agent.yaml
- test/README.md
- test/fixtures/agent-schema/invalid/menu-triggers/duplicate-triggers.agent.yaml
- test/fixtures/agent-schema/valid/prompts/valid-prompts-with-description.agent.yaml
- test/fixtures/agent-schema/valid/prompts/no-prompts.agent.yaml
- test/fixtures/agent-schema/invalid/persona/missing-role.agent.yaml
- test/fixtures/agent-schema/valid/metadata/empty-module-name-in-path.agent.yaml
- test/fixtures/agent-schema/invalid/yaml-errors/invalid-indentation.agent.yaml
- test/fixtures/agent-schema/invalid/prompts/missing-content.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/camel-case.agent.yaml
- test/fixtures/agent-schema/valid/metadata/wrong-module-value.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/leading-asterisk.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/snake-case.agent.yaml
- test/fixtures/agent-schema/invalid/top-level/missing-agent-key.agent.yaml
- test/fixtures/agent-schema/invalid/menu-triggers/trigger-with-spaces.agent.yaml
- test/fixtures/agent-schema/invalid/menu/empty-menu.agent.yaml
- test/fixtures/agent-schema/invalid/prompts/missing-id.agent.yaml
- test/fixtures/agent-schema/valid/metadata/module-agent-correct.agent.yaml
- test/fixtures/agent-schema/invalid/persona/empty-string-in-principles.agent.yaml
- test/fixtures/agent-schema/valid/menu/single-menu-item.agent.yaml
- test/fixtures/agent-schema/invalid/top-level/extra-top-level-keys.agent.yaml
- test/fixtures/agent-schema/valid/menu-commands/all-command-types.agent.yaml
- test/fixtures/agent-schema/valid/critical-actions/empty-critical-actions.agent.yaml
- test/fixtures/agent-schema/invalid/metadata/empty-name.agent.yaml
- test/fixtures/agent-schema/valid/menu-triggers/kebab-case-triggers.agent.yaml
- test/unit-test-schema.js
- .github/workflows/quality.yaml
- test/validate-agent-schema.js
- test/fixtures/agent-schema/valid/prompts/empty-prompts.agent.yaml
- test/fixtures/agent-schema/valid/metadata/malformed-path-treated-as-core.agent.yaml
- test/test-agent-schema.js
- test/fixtures/agent-schema/invalid/critical-actions/actions-as-string.agent.yaml
- test/fixtures/agent-schema/valid/prompts/valid-prompts-minimal.agent.yaml
- test/fixtures/agent-schema/valid/menu-commands/multiple-commands.agent.yaml
- test/fixtures/agent-schema/invalid/persona/empty-principles-array.agent.yaml
- test/fixtures/agent-schema/valid/menu-triggers/compound-triggers.agent.yaml
- test/fixtures/agent-schema/valid/metadata/core-agent-with-module.agent.yaml
- test/fixtures/agent-schema/invalid/prompts/empty-content.agent.yaml
- test/fixtures/agent-schema/valid/menu/multiple-menu-items.agent.yaml
- test/fixtures/agent-schema/invalid/metadata/extra-metadata-fields.agent.yaml
- test/fixtures/agent-schema/invalid/persona/extra-persona-fields.agent.yaml
- test/fixtures/agent-schema/valid/top-level/minimal-core-agent.agent.yaml
- test/schema/agent.js
- test/fixtures/agent-schema/valid/metadata/module-agent-missing-module.agent.yaml
- test/fixtures/agent-schema/invalid/critical-actions/empty-string-in-actions.agent.yaml
✅ Files skipped from review due to trivial changes (9)
- src/skills/bmad-cis-agent-presentation-master/bmad-skill-manifest.yaml
- src/skills/bmad-cis-agent-innovation-strategist/bmad-skill-manifest.yaml
- src/skills/bmad-cis-agent-creative-problem-solver/bmad-skill-manifest.yaml
- src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md
- src/skills/bmad-cis-agent-storyteller/SKILL.md
- src/skills/bmad-cis-agent-design-thinking-coach/bmad-skill-manifest.yaml
- src/skills/bmad-cis-agent-innovation-strategist/SKILL.md
- src/skills/bmad-cis-agent-storyteller/bmad-skill-manifest.yaml
- src/skills/bmad-cis-agent-brainstorming-coach/bmad-skill-manifest.yaml
| "test": "npm run test:schemas && npm run validate:schemas && npm run lint && npm run lint:md && npm run format:check", | ||
| "test:schemas": "node test/test-agent-schema.js", | ||
| "validate:schemas": "node test/validate-agent-schema.js" | ||
| "test": "npm run lint && npm run lint:md && npm run format:check" |
There was a problem hiding this comment.
npm test no longer verifies skill wiring/functionality
On Line 34, test now runs only style checks. That means broken skill manifests or invalid skill: references can still pass CI, even though this PR’s core behavior is skill conversion/resolution. Please keep at least one automated skill-validation smoke step in npm test (or an equivalent required CI job).
Suggested update
"scripts": {
+ "test:skills": "node tools/validate-skills.mjs",
- "test": "npm run lint && npm run lint:md && npm run format:check"
+ "test": "npm run lint && npm run lint:md && npm run format:check && npm run test:skills"
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 34, The test script currently runs only style checks
("test": "npm run lint && npm run lint:md && npm run format:check") so CI no
longer validates skill wiring; add or invoke a skill-validation smoke script
(e.g., create "validate:skills" or reuse existing skill check script) and
include it in the "test" pipeline so "npm test" runs style checks plus at least
one automated skill manifest/skill: reference validation step; update the "test"
script to run the new/existing skill validator after the lint/format steps and
ensure the validator exits non‑zero on failures.
| - Wild ideas today become innovations tomorrow. | ||
| - Humor and play are serious innovation tools. | ||
|
|
||
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. |
There was a problem hiding this comment.
Fix grammatical error.
"its important" should be "it's important" (contraction of "it is").
📝 Proposed fix
-You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona.
+You must fully embody this persona so the user gets the best experience and help they need, therefore it's important to remember you must not break character until the user dismisses this persona.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. | |
| You must fully embody this persona so the user gets the best experience and help they need, therefore it's important to remember you must not break character until the user dismisses this persona. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md` at line 26, Fix the
grammatical contraction in the SKILL.md sentence "You must fully embody this
persona so the user gets the best experience and help they need, therefore its
important to remember you must not break character until the users dismisses
this persona." by replacing "its important" with "it's important" and also
consider fixing "users dismisses" to "user dismisses" or "users dismiss" as
appropriate; locate the exact sentence in SKILL.md and apply the contraction and
plural noun fix so the line reads grammatically correct.
| - Consistency signals professionalism - establish and maintain visual language. | ||
| - Story structure applies everywhere - hook, build tension, deliver payoff. | ||
|
|
||
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. |
There was a problem hiding this comment.
Fix grammatical error.
Line 31 contains a subject-verb disagreement: "the users dismisses" should be "the user dismisses".
📝 Proposed fix
-You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona.
+You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the user dismisses this persona.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. | |
| You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the user dismisses this persona. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/skills/bmad-cis-agent-presentation-master/SKILL.md` at line 31, The
sentence in SKILL.md that reads "until the users dismisses this persona" has a
subject-verb agreement error; update that fragment to "until the user dismisses
this persona" (change "users dismisses" to "user dismisses") so the subject and
verb agree; locate the sentence in the SKILL.md content block for the persona
description and replace the plural/incorrect form with the singular/correct
form.
…nonicalId - Update name and canonicalId in all agent bmad-skill-manifest.yaml files - Remove deprecated canonicalId field from agent manifests - Update agent loading commands in docs/reference/agents.md - Update via-agent examples in docs/reference/workflows.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Refactor
Chores